RefactoringIncrementIIIStory

Meeting minutes

During the last meeting on 14-12 the following was decided:
  • To ensure that the projects stays active its time to attract more developers.
  • The demo-server must be updated more frequently
  • The last two increments are combined in one final increment
  • As soon as the refactorings are complete a first release is to be made.
  • To make a first install simpler we are going to create a way to define the majority of the application settings through the web browser -> FirstRunStory

Refactoring after increment III

  • Hibernate
    • OpenSessionInViewFilter is to be avoided as much as possible we are going to use manual session/transaction handling.
    • Relations in the model classes are to be handled through the managers so that we're never working with stale data.
    • After this refactoring the adding and editing of events should be a breeze.
  • Timezones must be handled consistently throughout the application
  • The javadoc should be made usefull. Because the panels are changed often only the domain is re-javadoced.

  • Views
    • The event list shows null when the description is not filled out
    • the time format does not match the users locale
    • after adding/editing an event the panel returns to the wrong view
    • Ajax should be turned on by default unless the user does not support it
    • There is no way to remove an event as off yet
    • The use of Panels for small components seems unnecessary, we should make more use of fragments
    • The weekview and monthview have a double entry for the summary, this should be a summary and the start time.

  • There is a lack of null-checks throughout some of the code. For example Event.isValidForDateRange().
  • Event contains logic specific to iCalendar. This should be made available through a manager call
  • The recurrence is incomplete, RDate is not taken into account.

task hours todo spend developer
Hibernate refactoring 20 0 20 Ivo
Timezone handling 8 0 14 Jochem
Cleanup javadoc 4 0 2 Jochem
The event list shows null when the description is not filled out 1 0 1 Ivo
the time format does not match the users locale 1 0 1 Ivo
after adding/editing an event the panel returns to the wrong view 4 0 2 Ivo
Ajax should be turned on by default unless the user does not support it 6 0 10 Ivo
There is no way to remove an event as off yet 2 0 3 Ivo
Replace unneccesary panels with fragments 5 0 4 Jochem
Add additional null-checks to recurrence code 2 0 1 Paul
Remove logic from event 3 0 3 Ivo
Add RDate support 4 0 1 Paul
Add time to week and month view (Locale dependent) 3 0 3 Paul
Total 63 0 65 0

-- IvoVanDongen - 16 Dec 2006

Topic revision: r13 - 20 Jan 2007 - 13:47:54 - JochemKolthof
 
This site is powered by the TWiki collaboration platformCopyright © by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback